Page MenuHomePhabricator
Differential D5754

Refactor InterpretNegatedOption() function
ClosedPublic
Actions

Authored by deadalnix on Apr 17 2020, 02:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING43e52180c78e: Refactor InterpretNegatedOption() function
rABC43e52180c78e: Refactor InterpretNegatedOption() function
Summary
  • added args parameter
  • renamed to InterpretOption()
  • removed code duplication

This is a partial backport of Core PR16097 : https://github.com/bitcoin/bitcoin/pull/16097/commits/e0d187dfeb18b026de22bd7960b2a50c2b958e1a

Depends on D5753

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16097-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10262
Build 18346: Default Diff Build & Tests
Build 18345: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 17 2020, 02:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2020, 02:49
teamcity edited the summary of this revision. (Show Details)Apr 17 2020, 02:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 17 2020, 02:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 17 2020, 03:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10262: Diff 18883.Apr 17 2020, 03:02
deadalnix added a child revision: D5755: Add Flags enum to ArgsManager.Apr 17 2020, 03:03
Fabien accepted this revision.Apr 17 2020, 11:26
This revision is now accepted and ready to land.Apr 17 2020, 11:26
Closed by commit rABC43e52180c78e: Refactor InterpretNegatedOption() function (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by deadalnix). · Explain WhyApr 17 2020, 14:46
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC43e52180c78e: Refactor InterpretNegatedOption() function.
deadalnix added a commit: rSTAGING43e52180c78e: Refactor InterpretNegatedOption() function.May 5 2020, 19:01

Revision Contents
Changeset List

PathSize
src/
util/
39 lines

Diff 18883

View Options

src/util/system.cpp

Loading...