Page MenuHomePhabricator
Differential D5768

scripted-diff: Use ArgsManager::DEBUG_ONLY flag
ClosedPublic
Actions

Authored by deadalnix on Apr 18 2020, 07:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING10ace580f586: scripted-diff: Use ArgsManager::DEBUG_ONLY flag
rABC10ace580f586: scripted-diff: Use ArgsManager::DEBUG_ONLY flag
Summary

-BEGIN VERIFY SCRIPT-
sed -i 's/unsigned int flags, const bool debug_only,/unsigned int flags,/' src/util/system.h src/util/system.cpp
sed -i 's/ArgsManager::NONE, debug_only/flags, false/' src/util/system.cpp
sed -i 's/arg.second.m_debug_only/(arg.second.m_flags \& ArgsManager::DEBUG_ONLY)/' src/util/system.cpp
sed -i 's/ArgsManager::ALLOW_ANY, true, OptionsCategory::/ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::/' $(git grep --files-with-matches 'AddArg(' src)
sed -i 's/ArgsManager::ALLOW_ANY, false, OptionsCategory::/ArgsManager::ALLOW_ANY, OptionsCategory::/' $(git grep --files-with-matches 'AddArg(' src)
-END VERIFY SCRIPT-

This is a partial backport of Core PR16097 : https://github.com/bitcoin/bitcoin/pull/16097/commits/fb4b9f9e3b433d8848832e2c2686cf7b1f212a5e

Depends on D5767

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16097-5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10287
Build 18395: Default Diff Build & Tests
Build 18394: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 18 2020, 07:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2020, 07:22
teamcity edited the summary of this revision. (Show Details)Apr 18 2020, 07:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 18 2020, 07:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix added a child revision: D5769: Remove unused m_debug_only member from Arg struct.Apr 18 2020, 07:27
teamcity added a comment.Apr 18 2020, 07:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10287: Diff 18929.Apr 18 2020, 07:39
Fabien accepted this revision.Apr 20 2020, 08:13
This revision is now accepted and ready to land.Apr 20 2020, 08:13
Closed by commit rABC10ace580f586: scripted-diff: Use ArgsManager::DEBUG_ONLY flag (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by deadalnix). · Explain WhyApr 20 2020, 13:29
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC10ace580f586: scripted-diff: Use ArgsManager::DEBUG_ONLY flag.
deadalnix added a commit: rSTAGING10ace580f586: scripted-diff: Use ArgsManager::DEBUG_ONLY flag.May 5 2020, 19:02

Revision Contents
Changeset List

PathSize
src/
bench/
24 lines
38 lines
48 lines
20 lines
5 lines
294 lines
qt/
18 lines
rpc/
test/
2 lines
seeder/
41 lines
test/
3 lines
2 lines
2 lines
util/
3 lines
15 lines
wallet/
41 lines

Diff 18929

View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/bitcoin-wallet.cpp

Loading...
View Options

src/chainparamsbase.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/rpc/test/server_tests.cpp

Loading...
View Options

src/seeder/main.cpp

Loading...
View Options

src/test/getarg_tests.cpp

Loading...
View Options

src/test/main.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...