Page MenuHomePhabricator
Differential D5781

Merge #14381: test: Add missing call to skip_if_no_cli()
ClosedPublic
Actions

Authored by jasonbcox on Apr 20 2020, 17:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGbc728213d1bb: Merge #14381: test: Add missing call to skip_if_no_cli()
rABCbc728213d1bb: Merge #14381: test: Add missing call to skip_if_no_cli()
Summary

ff94da7887 tests: Make appveyor run with --usecli (practicalswift)
db01839361 test: Add missing call to skip_if_no_cli() (practicalswift)

Pull request description:

Add missing call to `skip_if_no_cli()` as suggested by @MarcoFalke in #14365.

Tree-SHA512: b0a2ddfad0f81cc9544f63c4e490fb983d833a47c23522549d1200ea6a8a132b2cd4bf0d66b862ef3a548d8471128b80aea3525fb5dec65221e23f32a8d46746

Backport of Core PR14381

Test Plan
cmake -GNinja ..
ninja
test_runner.py wallet_*

cmake -GNinja -DBUILD_BITCOIN_CLI=OFF ..
ninja
test_runner.py wallet_*

These tests should be skipped with BUILD_BITCOIN_CLI=OFF:

wallet_createwallet --usecli
wallet_multiwallet --usecli

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Apr 20 2020, 17:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2020, 17:22
teamcity edited the summary of this revision. (Show Details)Apr 20 2020, 17:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 20 2020, 17:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.Apr 20 2020, 17:56
deadalnix added a subscriber: deadalnix.

Sounds like something that CI should check.

This revision is now accepted and ready to land.Apr 20 2020, 17:56
teamcity added a comment.Apr 20 2020, 17:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10308: Diff 18966.Apr 20 2020, 18:00
jasonbcox added a child revision: D5784: [build-configurations] Add build-without-cli.Apr 20 2020, 18:42
jasonbcox added a comment.Apr 20 2020, 18:44
In D5781#141467, @deadalnix wrote:

Sounds like something that CI should check.

Absolutely: D5784

jasonbcox added a child revision: D5788: Fix a bug where running test_runner.py --usecli would fail when built without bitcoin-cli.Apr 20 2020, 22:56
Closed by commit rABCbc728213d1bb: Merge #14381: test: Add missing call to skip_if_no_cli() (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyApr 20 2020, 23:24
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCbc728213d1bb: Merge #14381: test: Add missing call to skip_if_no_cli().
jasonbcox added a commit: rSTAGINGbc728213d1bb: Merge #14381: test: Add missing call to skip_if_no_cli().May 5 2020, 19:03

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
8 lines

Diff 18979

View Options

test/functional/test_framework/test_framework.py

Loading...