Merge #14298: [REST] improve performance for JSON calls
ClosedPublic
Actions

Authored by jasonbcox on Apr 20 2020, 18:27.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7c83d810c5dc: Merge #14298: [REST] improve performance for JSON calls
rABC7c83d810c5dc: Merge #14298: [REST] improve performance for JSON calls

Summary

30973e9844 [REST] improve performance for JSON calls (Antoine Le Calvez)

Pull request description:

JSON calls do not use the raw data generated for the .bin and .hex calls.

By moving the raw data creation into the .bin and .hex switch branches, JSON calls' performance is improved.

Light benchmarking indicates that fetching 2000 JSON headers is ~25% faster, fetching large JSON blocks is ~4% faster.

Tree-SHA512: 433552c89bac2469d041b48a4a991d5443e4026a3ad7dc5621685386029f22826484218642fa5130c268349a55524ecbc4e30d64c867bd6632e0edd24370cf11

Backport of Core PR14298

Test Plan

My computer is apparently too fast to measure these perf improvements reliably, but I tried this pre- and post-patch:

ninja check
bitcoind -rest
time curl localhost:8332/rest/headers/2000/<some-blockhash>.json
time curl localhost:8332/rest/block/<some-blockhash>.json

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr14298

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10310
Build 18441: Default Diff Build & Tests
Build 18440: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 20 2020, 18:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2020, 18:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.Apr 20 2020, 18:45

This revision is now accepted and ready to land.Apr 20 2020, 18:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10310: Diff 18969.Apr 20 2020, 18:48

Closed by commit rABC7c83d810c5dc: Merge #14298: [REST] improve performance for JSON calls (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyApr 22 2020, 17:58

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC7c83d810c5dc: Merge #14298: [REST] improve performance for JSON calls.

jasonbcox added a commit: rSTAGING7c83d810c5dc: Merge #14298: [REST] improve performance for JSON calls.May 5 2020, 19:04

Revision Contents
Changeset List

Path

Size

src/

rest.cpp

36 lines

Diff 18969

View Options

Merge #14298: [REST] improve performance for JSON callsClosedPublicActions