[backport#15864] Fix datadir handling
AbandonedPublic
Actions

Authored by majcosta on Apr 20 2020, 20:41.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

ffea41f5301d5582665cf10ba5c2b9547a1443de Enable all tests in feature_config_args.py (Hennadii Stepanov)
66f5c17f8a3fe06fc65191e379ffc04e43cbbc86 Use CheckDataDirOption() for code uniformity (Hennadii Stepanov)
7e33a18a34b1a9b0f115076c142661d6d30c0585 Fix datadir handling in bitcoin-cli (Hennadii Stepanov)
b28dada37465c0a773cf08b0e6766f0081bcb943 Fix datadir handling in bitcoin-qt (Hennadii Stepanov)
50824093bb2d68fe1393dfd636fab5f8795faa5d Fix datadir handling in bitcoind (Hennadii Stepanov)
740d41ce9f7fdf209366e930bd0fdcc6b1bc6b79 Add CheckDataDirOption() function (Hennadii Stepanov)
c1f325126cf51d28dce8da74bfdf5cd05ab237ea Return absolute path early in AbsPathForConfigVal (Hennadii Stepanov)

Pull request description:

Fix #15240, see: https://github.com/bitcoin/bitcoin/issues/15240#issuecomment-487353760
Fix #15745
Fix broken `feature_config_args.py` tests (disabled by MarcoFalke@fabe28a0cdcfa13e0e595a0905e3642a960d3077). All test are enabled now.
This PR is alternative to #13621.

User's `$HOME` directory is not touched unnecessarily now.

~To make reviewing easier only `bitcoind` code is modified (neither `bitcoin-cli` nor `bitcoin-qt`).~

Refs:
- https://github.com/bitcoin/bitcoin/issues/15745#issuecomment-479852569 by **laanwj**
- #16220

Top commit has no ACKs.

Tree-SHA512: 4a4cda10e0b67c8f374da0c9567003d2b566d948e7f8550fe246868b5794c15010e88ea206009480b9cd2f737f310a15e984f920730448f99a895893bed351df

This is a backport of Core PR15864

Depends on D5777

Test Plan

ninja check
./test_runner.py feature_config_args

Diff Detail

Repository

rABC Bitcoin ABC

Branch

init_error_for_all

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10313
Build 18447: Default Diff Build & Tests
Build 18446: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 20 2020, 20:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2020, 20:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta edited the summary of this revision. (Show Details)Apr 20 2020, 20:42

majcosta added a parent revision: D5777: [backport] init: Use InitError for all errors in bitcoind/qt and Fix datadir handling.

Harbormaster completed remote builds in B10313: Diff 18972.Apr 20 2020, 21:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

deadalnix requested changes to this revision.Apr 20 2020, 23:37

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/qt/bitcoin.cpp
620	Keep the dot. Not sure if there are other differences but original PR does not touch this.
626	Revert
test/functional/feature_config_args.py
154	This test clearly has not been backported properly.