Page MenuHomePhabricator

core -> ABC in extract_strings_qt.py
ClosedPublic

Authored by jasonbcox on Apr 21 2020, 00:04.

Details

Summary

make translate deletes nearly the whole src/qt/bitcoinstrings.cpp file because it's
looking for bitcoin-core and not bitcoin-abc.

Apparently we've never regenerated this file ever?

Test Plan
../configure
make -j8
cd src
make translate
arc lint

Not committed with this patch, but there should be some sane output in bitcoinstrings.cpp

Diff Detail

Repository
rABC Bitcoin ABC
Branch
extract-str
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10322
Build 18465: Default Diff Build & Tests
Build 18464: arc lint + arc unit

Event Timeline

deadalnix added a subscriber: deadalnix.

Do you have a sane output? Because I clearly don't.

green anyway because this is obviously a step in the right direction.

This revision is now accepted and ready to land.Apr 21 2020, 00:08
deadalnix requested changes to this revision.Apr 21 2020, 00:27

Please regenrate src/qt/bitcoinstrings.cpp

This revision now requires changes to proceed.Apr 21 2020, 00:27
share/qt/extract_strings_qt.py
77

@generated

Merged in changes from D5792

Generating these files depends on D5791 as far as I can tell, so I landed it first.

deadalnix requested changes to this revision.Apr 21 2020, 00:52

Look good except the overzealous interpretation of @generated.

You may want to splice it in in a way phab understands.

share/qt/extract_strings_qt.py
77 ↗(On Diff #18987)

lol. You got to do somethign here so that this file doesn't not appear generated by phabricator. contrib/seeds/generate-seeds.py is a good exemple.

I bet it is due to the multiline string that is used here.

This revision now requires changes to proceed.Apr 21 2020, 00:52
deadalnix requested changes to this revision.Apr 21 2020, 01:26

Both are still tagged as generated. As it turns out generate-seeds is too, so this is worth fixing: https://reviews.bitcoinabc.org/D3772#change-QXy06wMdqeAy

This revision now requires changes to proceed.Apr 21 2020, 01:26

Actually mark the file as non-generated....

Both are still tagged as generated. As it turns out generate-seeds is too, so this is worth fixing: https://reviews.bitcoinabc.org/D3772#change-QXy06wMdqeAy

Fixed for generate-seeds: D5793

This revision is now accepted and ready to land.Apr 21 2020, 14:13
This revision was automatically updated to reflect the committed changes.