Differential D5792

Mark translation files as @generated and update them
AbandonedPublic
Actions

Authored by jasonbcox on Apr 21 2020, 00:36.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

We've apparently never updated bitcoinstrings.cpp...

This patch adds the right @generated comment to these files so that Phabricator softly ignores
them during review and linting does not affect them.

This doesn't strictly depend on D5791, but good luck getting consistent output without it, so I'm adding it as a dependency.
Depends on D5791

Test Plan

../configure
make -j8
cd src
make translate

Diff Detail

Repository

rABC Bitcoin ABC

Branch

extract-str-gen

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10324
Build 18469: Default Diff Build & Tests
Build 18468: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 21 2020, 00:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 21 2020, 00:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox edited the summary of this revision. (Show Details)Apr 21 2020, 00:36

jasonbcox added a parent revision: D5791: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`.

jasonbcox mentioned this in D5790: core -> ABC in extract_strings_qt.py.Apr 21 2020, 00:44

Merged these changes into D5790

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10324: Diff 18985.Apr 21 2020, 00:48

Revision Contents
Changeset List

Path

Size

share/

qt/

extract_strings_qt.py

src/

qt/

bitcoinstrings.cpp

locale/

bitcoin_en.ts

1322 lines

Diff 18985

View Options

share/qt/extract_strings_qt.py

View Options

src/qt/bitcoinstrings.cpp

View Options

src/qt/locale/bitcoin_en.ts

Mark translation files as @generated and update themAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18985

share/qt/extract_strings_qt.py

src/qt/bitcoinstrings.cpp

src/qt/locale/bitcoin_en.ts

Mark translation files as @generated and update them
AbandonedPublic
Actions

Revision Contents
Changeset List