Page MenuHomePhabricator
Differential D5796

[CMAKE] Add a translate target
ClosedPublic
Actions

Authored by Fabien on Apr 21 2020, 14:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING01a30dedc54d: [CMAKE] Add a translate target
rABC01a30dedc54d: [CMAKE] Add a translate target
Summary

This behaves like the autotools translate target, updating the
bitcoin_en.ts and bitcoinstrings.cpp files.

Test Plan
ninja translate

Compare the output with autotools make translate: there are 2
additional translation strings from qt/splashscreen.cpp (after D5795).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 21 2020, 14:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 21 2020, 14:45
teamcity added a comment.Apr 21 2020, 14:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix requested changes to this revision.Apr 21 2020, 14:57
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
cmake/utils/translate.sh.in
25 ↗(On Diff #18997)

These are going away soon. Can this be delayed?

This revision now requires changes to proceed.Apr 21 2020, 14:57
teamcity added a comment.Apr 21 2020, 15:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10333: Diff 18997.Apr 21 2020, 15:00
Fabien planned changes to this revision.Apr 21 2020, 15:00

Ping me when it's ready, marking as changes planned for now.

Fabien updated this revision to Diff 19005.Apr 21 2020, 22:01

Rebase, add the regenerated translation files.

teamcity added a comment.Apr 21 2020, 22:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 21 2020, 22:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10336: Diff 19005.Apr 21 2020, 22:11
deadalnix requested changes to this revision.Apr 22 2020, 13:53
deadalnix added inline comments.
src/qt/CMakeLists.txt
593 ↗(On Diff #19005)

If the invocation is not managed by cmake, then I don't think it makes a lot of sense to have it be detected by cmake. Case in point: you need to detect it again in the bash script.

This revision now requires changes to proceed.Apr 22 2020, 13:53
Fabien updated this revision to Diff 19015.Apr 22 2020, 15:11

Manage all the required programs in the shell script.
This requires the executable to be in path which shouldn't be a big deal.

teamcity added a comment.Apr 22 2020, 15:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 22 2020, 15:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10344: Diff 19015.Apr 22 2020, 15:21
deadalnix accepted this revision.Apr 22 2020, 20:15
This revision is now accepted and ready to land.Apr 22 2020, 20:15
Closed by commit rABC01a30dedc54d: [CMAKE] Add a translate target (authored by Fabien). · Explain WhyApr 23 2020, 09:13
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC01a30dedc54d: [CMAKE] Add a translate target.
Fabien added a commit: rSTAGING01a30dedc54d: [CMAKE] Add a translate target.May 5 2020, 19:06

Revision Contents
Changeset List

PathSize
cmake/
utils/
36 lines
src/
qt/
13 lines
locale/
26 lines

Diff 19050

View Options

cmake/utils/translate.sh.in

Loading...
View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/qt/bitcoinstrings.cpp

Loading...
View Options

src/qt/locale/bitcoin_en.ts

Loading...