Page MenuHomePhabricator

[CMAKE] Add a translate target
ClosedPublic

Authored by Fabien on Apr 21 2020, 14:45.

Details

Summary

This behaves like the autotools translate target, updating the
bitcoin_en.ts and bitcoinstrings.cpp files.

Test Plan
ninja translate

Compare the output with autotools make translate: there are 2
additional translation strings from qt/splashscreen.cpp (after D5795).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_translate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10336
Build 18493: Default Diff Build & Tests
Build 18492: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Apr 21 2020, 14:57
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
cmake/utils/translate.sh.in
25 ↗(On Diff #18997)

These are going away soon. Can this be delayed?

This revision now requires changes to proceed.Apr 21 2020, 14:57
Fabien planned changes to this revision.Apr 21 2020, 15:00

Ping me when it's ready, marking as changes planned for now.

Rebase, add the regenerated translation files.

deadalnix requested changes to this revision.Apr 22 2020, 13:53
deadalnix added inline comments.
src/qt/CMakeLists.txt
593

If the invocation is not managed by cmake, then I don't think it makes a lot of sense to have it be detected by cmake. Case in point: you need to detect it again in the bash script.

This revision now requires changes to proceed.Apr 22 2020, 13:53

Manage all the required programs in the shell script.
This requires the executable to be in path which shouldn't be a big deal.

This revision is now accepted and ready to land.Apr 22 2020, 20:15
This revision was automatically updated to reflect the committed changes.