Page MenuHomePhabricator
Differential D5809

Pass rpc/abc RPC Results and Examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 22 2020, 20:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe6cc692608b8: Pass rpc/abc RPC Results and Examples to RPCHelpMan
rABCe6cc692608b8: Pass rpc/abc RPC Results and Examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs abcPatched
./checkrpc.sh RPCs master abcPatched abc.diff

Verify the changes in abc.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

abc.diff:

abc.diff671 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 22 2020, 20:43
Owners added a reviewer: Restricted Owners Package.Apr 22 2020, 20:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2020, 20:43
nakihito planned changes to this revision.Apr 22 2020, 20:43
teamcity edited the summary of this revision. (Show Details)Apr 22 2020, 20:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 22 2020, 20:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito mentioned this in D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.Apr 22 2020, 20:46
nakihito requested review of this revision.Apr 22 2020, 20:52
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 22 2020, 20:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10355: Diff 19032.Apr 22 2020, 20:55
nakihito planned changes to this revision.Apr 23 2020, 00:14
nakihito added a child revision: D5815: Pass rpc/server RPC results and examples to RPCHelpMan.Apr 23 2020, 00:31
nakihito requested review of this revision.Apr 23 2020, 00:31
nakihito edited the test plan for this revision. (Show Details)
Fabien requested changes to this revision.Apr 23 2020, 09:00
Fabien added a subscriber: Fabien.

Please fix the weird layout

src/rpc/abc.cpp
25 ↗(On Diff #19032)

??? This is an interesting layout.

51 ↗(On Diff #19032)

Dito

This revision now requires changes to proceed.Apr 23 2020, 09:00
Fabien accepted this revision.Apr 23 2020, 09:08

OK I gave it a try: the linter insists and I can't find a way to avoid it.

This revision is now accepted and ready to land.Apr 23 2020, 09:08
Closed by commit rABCe6cc692608b8: Pass rpc/abc RPC Results and Examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 23 2020, 18:03
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCe6cc692608b8: Pass rpc/abc RPC Results and Examples to RPCHelpMan.
nakihito added a commit: rSTAGINGe6cc692608b8: Pass rpc/abc RPC Results and Examples to RPCHelpMan.May 5 2020, 19:06

Revision Contents
Changeset List

PathSize
src/
rpc/
52 lines
48 lines
96 lines

Diff 19061

View Options

src/rpc/abc.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...