Make sure build_* devtools scripts' default build directories always exist
ClosedPublic
Actions

Authored by jasonbcox on Apr 22 2020, 23:59.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf153f5ac6cdc: Make sure build_* devtools scripts' default build directories always exist
rABCf153f5ac6cdc: Make sure build_* devtools scripts' default build directories always exist

Summary

Both of these scripts assume the build directory already exists.
This patch makes sure it exists so the scripts do not fail otherwise.

Test Plan

rm -rf build
./contrib/devtools/build_cmake.sh

rm -rf build
THREADS=8 ./contrib/devtools/build_autotools.sh

Diff Detail

Repository

rABC Bitcoin ABC

Branch

devtools-build

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10362
Build 18545: Default Diff Build & Tests
Build 18544: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 22 2020, 23:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2020, 23:59

jasonbcox edited the test plan for this revision. (Show Details)Apr 23 2020, 00:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10362: Diff 19047.Apr 23 2020, 00:18

Fabien accepted this revision.Apr 23 2020, 08:47

This revision is now accepted and ready to land.Apr 23 2020, 08:47

Closed by commit rABCf153f5ac6cdc: Make sure build_* devtools scripts' default build directories always exist (authored by jasonbcox). · Explain WhyApr 23 2020, 15:49

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCf153f5ac6cdc: Make sure build_* devtools scripts' default build directories always exist.

jasonbcox added a commit: rSTAGINGf153f5ac6cdc: Make sure build_* devtools scripts' default build directories always exist.May 5 2020, 19:06

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

build_autotools.sh

1 line

build_cmake.sh

1 line

Diff 19047

View Options

contrib/devtools/build_autotools.sh