Page MenuHomePhabricator

Pass zmq RPC results and examples to RPCHelpMan
ClosedPublic

Authored by nakihito on Apr 23 2020, 19:47.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING6cc421370619: Pass zmq RPC results and examples to RPCHelpMan
rABC6cc421370619: Pass zmq RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs zmqPatched
./checkrpc.sh RPCs master zmqPatched zmq.diff

Verify zmq.diff does not exist.

Scripts:


Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-zmq
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10369
Build 18559: Default Diff Build & Tests
Build 18558: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 23 2020, 19:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Apr 23 2020, 23:37