Page MenuHomePhabricator

Merge #14456: test: forward timeouts properly in send_blocks_and_test
ClosedPublic

Authored by jasonbcox on Apr 24 2020, 00:45.

Details

Summary

94e21c1501 test: forward timeouts properly in send_blocks_and_test (James O'Beirne)

Pull request description:

Small change motivated by frustrations while writing `feature_block` tests; when a timeout is passed to `send_blocks_and_test` it isn't forwarded onto constituent waiting calls - you can end up waiting 60 seconds when you articulated e.g. 5. Respect the given timeout all the way down.

Tree-SHA512: 3a964764fc5e3431ae3b17bd642a27a1bd4526541a799ef63696c9dab0289a005a13d645770be6e46ea262d22a58f79d2b407293a39397b036f616fe20c21241

Backport of Core PR14456

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14456
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10373
Build 18567: Default Diff Build & Tests
Build 18566: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 24 2020, 08:16