Add a deprecation notice for the autotools build system
ClosedPublic
Actions

Authored by Fabien on Apr 24 2020, 13:14.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGb753429cf337: Add a deprecation notice for the autotools build system
rABCb753429cf337: Add a deprecation notice for the autotools build system

Summary

This add a mandatory option to run the configure script. The configure
stage will fail if the --enable-deprecated-build-system is not set,
and an error message instructs the user of the deprecation.

Depends on D5823.

Test Plan

./configure

Check it fails early with the error message

./configure --enable-deprecated-build-system
make

Check the build succeeds as usual.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 24 2020, 13:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 13:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-autotools) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10377: Diff 19080.Apr 24 2020, 13:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-autotools) passed.

Are we 100% positive this is at feature parity?

configure.ac
109 ↗	(On Diff #19080)	link to doc would be handy here

deadalnix requested changes to this revision.Apr 24 2020, 15:17

This revision now requires changes to proceed.Apr 24 2020, 15:17

Link to the doc in the deprecation message.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

I did another pass of review of the configure.ac and *.am files before submitting this diff, and the only missing feature is the option to use the system version of univalue.
This option was introduced by core for people willing to use the upstream version rather than their own fork, but since we are following the upstream version I don't think it is very useful for us.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10379: Diff 19085.Apr 24 2020, 16:44

deadalnix accepted this revision.Apr 24 2020, 16:57

This revision is now accepted and ready to land.Apr 24 2020, 16:57

Closed by commit rABCb753429cf337: Add a deprecation notice for the autotools build system (authored by Fabien). · Explain WhyApr 24 2020, 20:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb753429cf337: Add a deprecation notice for the autotools build system.

Fabien added a commit: rSTAGINGb753429cf337: Add a deprecation notice for the autotools build system.May 5 2020, 19:07