Page MenuHomePhabricator
Differential D5835

Remove unnecessary --force-yes from installation script
ClosedPublic
Actions

Authored by jasonbcox on Apr 24 2020, 23:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING151039ebdaa1: Remove unnecessary --force-yes from installation script
rABC151039ebdaa1: Remove unnecessary --force-yes from installation script
Summary

--force-yes is not recommended (see https://lists.debian.org/debian-devel/2015/06/msg00145.html ), and we download the proper keys,
so it's not clear why this is needed.

Test Plan

CI should build and pass tests without issue

Diff Detail

Repository
rABC Bitcoin ABC
Branch
setup-force-yes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10396
Build 18613: Default Diff Build & Tests
Build 18612: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 24 2020, 23:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 23:42
jasonbcox planned changes to this revision.Apr 24 2020, 23:42
jasonbcox edited the summary of this revision. (Show Details)Apr 24 2020, 23:42
teamcity added a comment.Apr 24 2020, 23:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox added a child revision: D5836: Make sure we're using the same version of clang tools for everything.Apr 24 2020, 23:47
teamcity added a comment.Apr 24 2020, 23:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10396: Diff 19110.Apr 24 2020, 23:57
jasonbcox requested review of this revision.Apr 24 2020, 23:59
Fabien accepted this revision.Apr 25 2020, 00:27
This revision is now accepted and ready to land.Apr 25 2020, 00:27
jasonbcox updated this revision to Diff 19159.Apr 27 2020, 15:45

Rebase

teamcity added a comment.Apr 27 2020, 15:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 27 2020, 16:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10428: Diff 19159.Apr 27 2020, 16:01
Closed by commit rABC151039ebdaa1: Remove unnecessary --force-yes from installation script (authored by jasonbcox). · Explain WhyApr 27 2020, 16:50
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC151039ebdaa1: Remove unnecessary --force-yes from installation script.
jasonbcox added a commit: rSTAGING151039ebdaa1: Remove unnecessary --force-yes from installation script.May 5 2020, 19:09

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
4 lines

Diff 19110

View Options

contrib/teamcity/setup-debian-buster.sh

Loading...