Page MenuHomePhabricator
Differential D5848

bench: Add block assemble benchmark
ClosedPublic
Actions

Authored by deadalnix on Apr 26 2020, 23:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING4de1bab17af0: bench: Add block assemble benchmark
rABC4de1bab17af0: bench: Add block assemble benchmark
Summary

This is a backport of Core PR13219 and PR13806 . Due to many backport being done out of oder or improperly, this contains elements of PR15413 and PR15788

Test Plan
make check
./src/bench/bench_bitcoin

Check that the new benchmark is run.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13219
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10418
Build 18657: Default Diff Build & Tests
Build 18656: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 26 2020, 23:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2020, 23:03
teamcity edited the summary of this revision. (Show Details)Apr 26 2020, 23:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 26 2020, 23:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 26 2020, 23:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10418: Diff 19139.Apr 26 2020, 23:12
deadalnix added a child revision: D5849: Backport leftovers from 15788.Apr 26 2020, 23:25
Fabien requested changes to this revision.Apr 27 2020, 09:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/bench/block_assemble.cpp
13

Remove

16

Remove

This revision now requires changes to proceed.Apr 27 2020, 09:12
deadalnix added inline comments.Apr 27 2020, 12:37
src/bench/block_assemble.cpp
79

txmempool is needed here.

deadalnix updated this revision to Diff 19150.Apr 27 2020, 12:53

Remove useless list include

Fabien accepted this revision.Apr 27 2020, 13:06
This revision is now accepted and ready to land.Apr 27 2020, 13:06
This revision was landed with ongoing or failed builds.Apr 27 2020, 13:20
Closed by commit rABC4de1bab17af0: bench: Add block assemble benchmark (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC4de1bab17af0: bench: Add block assemble benchmark.
teamcity added a comment.Apr 27 2020, 13:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 27 2020, 13:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10422: Diff 19150.Apr 27 2020, 13:40
deadalnix added a commit: rSTAGING4de1bab17af0: bench: Add block assemble benchmark.May 5 2020, 19:09

Revision Contents
Changeset List

PathSize
src/
1 line
bench/
1 line
92 lines

Diff 19139

View Options

src/Makefile.bench.include

Loading...
View Options

src/bench/CMakeLists.txt

Loading...
View Options

src/bench/block_assemble.cpp

Loading...