Page MenuHomePhabricator

Port of bitcoin/#10958 - leveldb patches
ClosedPublic

Authored by kyuupichan on Oct 5 2017, 08:33.

Details

Summary

Includes:

bitcoin-core/leveldb#2: Prefer std::atomic over MemoryBarrier (Pieter Wuille)
bitcoin-core/leveldb#5: Move helper functions out of sse4.2 object (Cory Fields)
bitcoin-core/leveldb#6: Fixes typo (Dimitris Tsapakidis)
bitcoin-core/leveldb#10: Clean up compile-time warnings (gcc 7.1) (Matt Corallo)
bitcoin-core/leveldb#11: fixup define checks. Cleans up some oopses from #5 (Cory Fields)

Removes many warnings on MacOSX of the form:

In file included from leveldb/util/cache.cc:10:
In file included from ./leveldb/port/port.h:14:
In file included from ./leveldb/port/port_posix.h:47:
./leveldb/port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use
    std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
      OSMemoryBarrier();
      ^

The bitcoin core patches have been included in BU already by sickpig.

Test Plan

make check. Installed and running fine.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
leveldb-patches
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 946
Build 946: arc lint + arc unit

Event Timeline

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptOct 5 2017, 08:33
This revision is now accepted and ready to land.Oct 5 2017, 12:45
Closed by commit rABC26bef497950b: Port of bitcoin/#10958 - leveldb patches (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by kyuupichan). · Explain WhyOct 5 2017, 13:11
This revision was automatically updated to reflect the committed changes.