Merge #15947: Install bitcoin-wallet manpage
ClosedPublic
Actions

Authored by jasonbcox on Apr 27 2020, 16:50.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa2715122edec: Merge #15947: Install bitcoin-wallet manpage
rABCa2715122edec: Merge #15947: Install bitcoin-wallet manpage

Summary

00d110463aed12ecdc6e9c2bf47d9ef61d19fa9d Install bitcoin-wallet manpage. (Daniel Kraft)

Pull request description:

This change marks the already-existing `bitcoin-wallet.1` manpage file for installation together with the others.  Previously, only `bitcoind.1`, `bitcoin-cli.1`, `bitcoin-tx.1` and `bitcoin-qt.1` would be installed.

ACKs for commit 00d110:

laanwj:
  utACK 00d110463aed12ecdc6e9c2bf47d9ef61d19fa9d
practicalswift:
  utACK 00d110463aed12ecdc6e9c2bf47d9ef61d19fa9d

Tree-SHA512: ca846e414548f1dc774f460edca2e17d7d619c7e6f0d18db0c58c09e04f9d43c6964fcf2bacb5b1eae94de9c5fdda86abf258ef6b78b0f693715d070dfc10f08

Backport of Core PR15947

We're generating the bitcoin-wallet manpages, but they still need to be installed.

Depends on D5855

Test Plan

sudo ninja install
man bitcoin-wallet

sudo make install
man bitcoin-wallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Apr 27 2020, 16:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2020, 16:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10431: Diff 19162.Apr 27 2020, 16:59

This change marks the already-existing bitcoin-wallet.1 manpage file for installation together with the others. Previously, only bitcoind.1, bitcoin-cli.1, bitcoin-tx.1 and bitcoin-qt.1 would be installed.

Well, it doesn't exist for us, so there is something else that nees to be done.

This revision now requires changes to proceed.Apr 27 2020, 18:20

I missed this was stacked.

This revision is now accepted and ready to land.Apr 27 2020, 18:21

Closed by commit rABCa2715122edec: Merge #15947: Install bitcoin-wallet manpage (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyApr 27 2020, 22:32

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCa2715122edec: Merge #15947: Install bitcoin-wallet manpage.

jasonbcox added a commit: rSTAGINGa2715122edec: Merge #15947: Install bitcoin-wallet manpage.May 5 2020, 19:10