Page MenuHomePhabricator
Differential D5857

Pass rpc/rawtransaction RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 27 2020, 17:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING22f5cdd265bc: Pass rpc/rawtransaction RPC results and examples to RPCHelpMan
rABC22f5cdd265bc: Pass rpc/rawtransaction RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rawtxn1.diff

Verify rawtxn1.diff does not exist.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-rawtxn
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10432
Build 18685: Default Diff Build & Tests
Build 18684: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 27 2020, 17:37
Owners added a reviewer: Restricted Owners Package.Apr 27 2020, 17:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2020, 17:37
teamcity edited the summary of this revision. (Show Details)Apr 27 2020, 17:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Apr 27 2020, 18:25
This revision is now accepted and ready to land.Apr 27 2020, 18:25
teamcity added a comment.Apr 27 2020, 18:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 27 2020, 18:41

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10432: Diff 19166.Apr 27 2020, 18:41
Closed by commit rABC22f5cdd265bc: Pass rpc/rawtransaction RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 27 2020, 21:22
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC22f5cdd265bc: Pass rpc/rawtransaction RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGING22f5cdd265bc: Pass rpc/rawtransaction RPC results and examples to RPCHelpMan.May 5 2020, 19:10

Revision Contents
Changeset List

PathSize
src/
rpc/
703 lines

Diff 19166

View Options

src/rpc/rawtransaction.cpp

Loading...