Page MenuHomePhabricator

Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan
ClosedPublic

Authored by nakihito on Apr 28 2020, 23:30.

Details

Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched blockchain2.diff

Verify changes in blockchain2.diff.

Scripts:


blockchain2.diff:

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-blockchain2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10457
Build 18734: Default Diff Build & Tests
Build 18733: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 28 2020, 23:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the test plan for this revision. (Show Details)
Fabien requested changes to this revision.Apr 29 2020, 07:25
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
2013

This seems to be part of PR14877 https://github.com/bitcoin/bitcoin/pull/14877 which appear to be ported along with PR14796 ?. Please remove and make sure there is no leftover in the end.

This revision now requires changes to proceed.Apr 29 2020, 07:25
This revision is now accepted and ready to land.Apr 29 2020, 19:10