Page MenuHomePhabricator
Differential D5876

Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 28 2020, 23:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc03c766cf334: Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan
rABCc03c766cf334: Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched blockchain2.diff

Verify changes in blockchain2.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

blockchain2.diff:

blockchain2.diff497 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-blockchain2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10457
Build 18734: Default Diff Build & Tests
Build 18733: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 28 2020, 23:30
Owners added a reviewer: Restricted Owners Package.Apr 28 2020, 23:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 23:30
nakihito planned changes to this revision.Apr 28 2020, 23:30
teamcity edited the summary of this revision. (Show Details)Apr 28 2020, 23:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 28 2020, 23:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito requested review of this revision.Apr 28 2020, 23:32
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 28 2020, 23:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10457: Diff 19216.Apr 28 2020, 23:42
Fabien requested changes to this revision.Apr 29 2020, 07:25
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
2013

This seems to be part of PR14877 https://github.com/bitcoin/bitcoin/pull/14877 which appear to be ported along with PR14796 ?. Please remove and make sure there is no leftover in the end.

This revision now requires changes to proceed.Apr 29 2020, 07:25
nakihito updated this revision to Diff 19249.Apr 29 2020, 18:08

Removed default value.

teamcity added a comment.Apr 29 2020, 18:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito edited the test plan for this revision. (Show Details)Apr 29 2020, 18:12
teamcity added a comment.Apr 29 2020, 18:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10478: Diff 19249.Apr 29 2020, 18:21
Fabien accepted this revision.Apr 29 2020, 19:10
This revision is now accepted and ready to land.Apr 29 2020, 19:10
Closed by commit rABCc03c766cf334: Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 29 2020, 23:40
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCc03c766cf334: Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGINGc03c766cf334: Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan.May 5 2020, 19:13

Revision Contents
Changeset List

PathSize
src/
rpc/
1106 lines

Diff 19216

View Options

src/rpc/blockchain.cpp

Loading...