Make bitcoin-util use the emulator as needed
ClosedPublic
Actions

Authored by Fabien on Apr 29 2020, 11:33.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGd9be7ac17f8e: Make bitcoin-util use the emulator as needed
rABCd9be7ac17f8e: Make bitcoin-util use the emulator as needed

Summary

By reading the config file, bitcoin-util can determine if an emulator is
needed. This is useful for running with wine or qemu.

Depends on D5878.

Test Plan

Prerequisite

sudo apt install qemu-user-static

Then:

cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/LinuxAArch64.cmake \
  -DCMAKE_CROSSCOMPILING_EMULATOR=$(command -v qemu-aarch64-static)
QEMU_LD_PREFIX=/usr/aarch64-linux-gnu ninja check-bitcoin-util

Sanity check for regression:

cmake -GNinja ..
ninja check-bitcoin-util

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 29 2020, 11:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2020, 11:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10461: Diff 19220.Apr 29 2020, 11:42

Fabien edited the summary of this revision. (Show Details)Apr 29 2020, 12:19

Fabien added a parent revision: D5878: Allow for using an emulator for the functional test framework.

deadalnix accepted this revision.Apr 29 2020, 12:32

This revision is now accepted and ready to land.Apr 29 2020, 12:32

Closed by commit rABCd9be7ac17f8e: Make bitcoin-util use the emulator as needed (authored by Fabien). · Explain WhyApr 29 2020, 12:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd9be7ac17f8e: Make bitcoin-util use the emulator as needed.

Fabien mentioned this in D5873: [CI] Run the tests for AArch64.Apr 29 2020, 13:04

Fabien added a commit: rSTAGINGd9be7ac17f8e: Make bitcoin-util use the emulator as needed.May 5 2020, 19:12

Revision Contents
Changeset List

Path

Size

test/

util/

bitcoin-util-test.py

2 lines

Diff 19227

View Options

test/util/bitcoin-util-test.py

Make bitcoin-util use the emulator as neededClosedPublicActions