Page MenuHomePhabricator
Differential D5885

Rename includeconf variables for clarity
ClosedPublic
Actions

Authored by deadalnix on Apr 29 2020, 14:41.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe594f5b1be4e: Rename includeconf variables for clarity
rABCe594f5b1be4e: Rename includeconf variables for clarity
Summary

includeconf -> conf_file_names
to_include -> conf_file_name
include_config -> conf_file_stream

Suggestion from John Newbery <john@johnnewbery.com> in
https://github.com/bitcoin/bitcoin/pull/15934#discussion_r343905138

This is a partial backport of Core PR15934 : https://github.com/bitcoin/bitcoin/pull/15934/commits/5a84aa880f6da0bac0e2144733fdef3b8558c761

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15934-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10472
Build 18764: Default Diff Build & Tests
Build 18763: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 29 2020, 14:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2020, 14:41
teamcity edited the summary of this revision. (Show Details)Apr 29 2020, 14:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 29 2020, 14:41

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 29 2020, 14:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10472: Diff 19235.Apr 29 2020, 14:51
jasonbcox accepted this revision.Apr 29 2020, 15:04
This revision is now accepted and ready to land.Apr 29 2020, 15:04
Closed by commit rABCe594f5b1be4e: Rename includeconf variables for clarity (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyApr 29 2020, 15:10
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCe594f5b1be4e: Rename includeconf variables for clarity.
deadalnix added a commit: rSTAGINGe594f5b1be4e: Rename includeconf variables for clarity.May 5 2020, 19:12

Revision Contents
Changeset List

PathSize
src/
util/
48 lines

Diff 19235

View Options

src/util/system.cpp

Loading...