Page MenuHomePhabricator
Differential D5889

gui: Drop boost::scoped_array and use wchar_t API explicitly on Windows
ClosedPublic
Actions

Authored by deadalnix on Apr 29 2020, 15:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc61d5a151ded: gui: Drop boost::scoped_array and use wchar_t API explicitly on Windows
rABCc61d5a151ded: gui: Drop boost::scoped_array and use wchar_t API explicitly on Windows
Summary
  • Drop boost::scoped_array
  • gui: get special folder in unicode

This is a backport of Core PR13734

Test Plan
make check

Run bitcoin-qt on win64

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13734
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10476
Build 18772: Default Diff Build & Tests
Build 18771: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 29 2020, 15:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2020, 15:48
teamcity edited the summary of this revision. (Show Details)Apr 29 2020, 15:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 29 2020, 15:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10476: Diff 19245.Apr 29 2020, 15:59
teamcity added a comment.Apr 29 2020, 15:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien accepted this revision.Apr 29 2020, 19:09
This revision is now accepted and ready to land.Apr 29 2020, 19:09
Closed by commit rABCc61d5a151ded: gui: Drop boost::scoped_array and use wchar_t API explicitly on Windows (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by deadalnix). · Explain WhyApr 29 2020, 21:20
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc61d5a151ded: gui: Drop boost::scoped_array and use wchar_t API explicitly on Windows.
deadalnix added a commit: rSTAGINGc61d5a151ded: gui: Drop boost::scoped_array and use wchar_t API explicitly on Windows.May 5 2020, 19:13

Revision Contents
Changeset List

PathSize
src/
qt/
33 lines
util/
6 lines
test/
lint/
1 line

Diff 19245

View Options

src/qt/guiutil.cpp

Loading...
View Options

src/util/system.cpp

Loading...
View Options

test/lint/lint-boost-dependencies.sh

Loading...