Page MenuHomePhabricator
Differential D5921

Pass pruneblockchain RPC Results and Examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 30 2020, 21:15.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING69f5edb69071: Pass pruneblockchain RPC Results and Examples to RPCHelpMan
rABC69f5edb69071: Pass pruneblockchain RPC Results and Examples to RPCHelpMan
Summary

Accidentally skipped over this one when backporting the changes to the
other RPCs in blockchain.cpp.

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched pruneblockchain.diff

Verify pruneblockchain.diff does not exist.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-pruneblockchain
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10527
Build 18868: Default Diff Build & Tests
Build 18867: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 30 2020, 21:15
Owners added a reviewer: Restricted Owners Package.Apr 30 2020, 21:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2020, 21:15
teamcity edited the summary of this revision. (Show Details)Apr 30 2020, 21:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 30 2020, 21:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10527: Diff 19322.Apr 30 2020, 21:24
teamcity added a comment.Apr 30 2020, 21:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

jasonbcox accepted this revision.Apr 30 2020, 22:35
This revision is now accepted and ready to land.Apr 30 2020, 22:35
Closed by commit rABC69f5edb69071: Pass pruneblockchain RPC Results and Examples to RPCHelpMan (authored by nakihito). · Explain WhyMay 1 2020, 01:07
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC69f5edb69071: Pass pruneblockchain RPC Results and Examples to RPCHelpMan.
nakihito added a commit: rSTAGING69f5edb69071: Pass pruneblockchain RPC Results and Examples to RPCHelpMan.May 5 2020, 19:16

Revision Contents
Changeset List

PathSize
src/
rpc/
34 lines

Diff 19322

View Options

src/rpc/blockchain.cpp

Loading...