Page MenuHomePhabricator

Remove config managed RPC user/pass
ClosedPublic

Authored by deadalnix on Apr 30 2020, 22:42.

Details

Summary

The user/pass is read from garg and stored into the config, to be fetched from there again by the exact same module. Even if we can move away from having so much global state, then a member variable for the http thing would make sense, not the config.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Also do it for CORS config

This revision is now accepted and ready to land.May 1 2020, 16:07
This revision was automatically updated to reflect the committed changes.