Page MenuHomePhabricator

[rpc] mining: Omit uninitialized currentblockweight, currentblocktx
ClosedPublic

Authored by deadalnix on May 3 2020, 23:41.

Details

Summary

This is a backport of Core PR15383

Obviously currentblockweight => currentblocksize for us.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15383
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10566
Build 18943: Default Diff Build & Tests
Build 18942: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.May 4 2020, 07:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/mining_basic.py
53

This would cause the test without wallet to fail. Either use a generatetoaddress or the skip directive is there is no wallet.
It's weird that core still has this...

This revision now requires changes to proceed.May 4 2020, 07:02

Fix the test when runnign without wallet.

This revision is now accepted and ready to land.May 4 2020, 13:47
This revision was landed with ongoing or failed builds.May 4 2020, 14:00
This revision was automatically updated to reflect the committed changes.