Page MenuHomePhabricator
Differential D5947

[backport#15646] [tests] Add test for wallet rebroadcasts
ClosedPublic
Actions

Authored by majcosta on May 4 2020, 08:24.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING319ac53d2717: [backport#15646] [tests] Add test for wallet rebroadcasts
rABC319ac53d2717: [backport#15646] [tests] Add test for wallet rebroadcasts
Summary

The existing wallet_resendwallettransactions.py test only tests the
resendwallettransactions RPC. It does not test whether transactions are
actually rebroadcast, or whether the rebroadcast logic is called on a
timer.

This commit updates the test to not use the resendwallettransactions RPC and
test that transactions are rebroadcast on a timer.

This is a backport of Core PR15646

Test Plan
cmake .. -GNinja
./test/functional/test_runner.py wallet_resendwallettransactions.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 4 2020, 08:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2020, 08:24
teamcity edited the summary of this revision. (Show Details)May 4 2020, 08:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D5948: [backport#15632] [wallet] Keep track of the best block time in the wallet.May 4 2020, 08:27
teamcity added a comment.May 4 2020, 08:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 4 2020, 08:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10569: Diff 19395.May 4 2020, 08:40
majcosta requested review of this revision.May 4 2020, 08:40
jasonbcox accepted this revision.May 4 2020, 15:43
This revision is now accepted and ready to land.May 4 2020, 15:43
Closed by commit rABC319ac53d2717: [backport#15646] [tests] Add test for wallet rebroadcasts (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 4 2020, 17:46
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC319ac53d2717: [backport#15646] [tests] Add test for wallet rebroadcasts.
majcosta added a commit: rSTAGING319ac53d2717: [backport#15646] [tests] Add test for wallet rebroadcasts.May 5 2020, 19:18

Revision Contents
Changeset List

PathSize
test/
functional/
79 lines

Diff 19409

View Options

test/functional/wallet_resendwallettransactions.py

Loading...