Suggested wallet code cleanups from #14711
ClosedPublic
Actions

Authored by Fabien on May 4 2020, 19:59.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7bd5ac0f8c1c: Suggested wallet code cleanups from #14711
rABC7bd5ac0f8c1c: Suggested wallet code cleanups from #14711

Summary

This implements suggested changes from #14711 review comments that
didn't make make it in before merging.

There are no changes in behavior in this PR, just documentation updates,
simplifications, and variable renames.

Backport of core PR15342.

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR15342

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10579
Build 18968: Default Diff Build & Tests
Build 18967: arc lint + arc unit

Event Timeline

Fabien created this revision.May 4 2020, 19:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2020, 19:59

Fabien requested review of this revision.May 4 2020, 19:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10579: Diff 19418.May 4 2020, 20:09

jasonbcox accepted this revision.May 4 2020, 20:27

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/wallet/rpcwallet.cpp
4016	Note to other reviewers: This essentially skips over PR15279, but it doesn't matter because that PR is only a fixup for this help string. This patch brings this text most up-to-date.

This revision is now accepted and ready to land.May 4 2020, 20:27

Closed by commit rABC7bd5ac0f8c1c: Suggested wallet code cleanups from #14711 (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyMay 4 2020, 21:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7bd5ac0f8c1c: Suggested wallet code cleanups from #14711.

Fabien mentioned this in D5955: wallet: Fixup rescanblockchain result doc.May 4 2020, 21:27

Fabien mentioned this in rABC3361af538cf2: wallet: Fixup rescanblockchain result doc.May 4 2020, 21:42

Fabien added a commit: rSTAGING7bd5ac0f8c1c: Suggested wallet code cleanups from #14711.May 5 2020, 19:19

Fabien mentioned this in rSTAGING3361af538cf2: wallet: Fixup rescanblockchain result doc.