Page MenuHomePhabricator
Differential D5966

tests: write the notification to different files to avoid race condition
ClosedPublic
Actions

Authored by Fabien on May 5 2020, 14:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING0011ed83a2f3: tests: write the notification to different files to avoid race condition
rABC0011ed83a2f3: tests: write the notification to different files to avoid race condition
Summary

Backport of core PR14275.

This is slighly adapted to not reduce large fork coverage but allow the
test to pass on windows.

Test Plan
./test/functional/test_runner.py feature_notifications

Ran on Linux, windows (depends on D5964) and OSX for sanity.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14275
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10593
Build 18996: Default Diff Build & Tests
Build 18995: arc lint + arc unit

Event Timeline

Fabien created this revision.May 5 2020, 14:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2020, 14:58
Fabien requested review of this revision.May 5 2020, 14:58
teamcity edited the summary of this revision. (Show Details)May 5 2020, 14:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 5 2020, 15:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 5 2020, 15:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10593: Diff 19441.May 5 2020, 15:12
deadalnix accepted this revision.May 5 2020, 19:34
This revision is now accepted and ready to land.May 5 2020, 19:34
Closed by commit rABC0011ed83a2f3: tests: write the notification to different files to avoid race condition (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyMay 6 2020, 09:25
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0011ed83a2f3: tests: write the notification to different files to avoid race condition.
Fabien added a commit: rSTAGING0011ed83a2f3: tests: write the notification to different files to avoid race condition.May 6 2020, 14:35

Revision Contents
Changeset List

PathSize
test/
functional/
93 lines

Diff 19441

View Options

test/functional/feature_notifications.py

Loading...