Page MenuHomePhabricator
Differential D5980

Merge #16299: bench: Move generated data to a dedicated translation unit
ClosedPublic
Actions

Authored by jasonbcox on May 6 2020, 17:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING33b30bc21b60: Merge #16299: bench: Move generated data to a dedicated translation unit
rABC33b30bc21b60: Merge #16299: bench: Move generated data to a dedicated translation unit
Summary

3d60a03a7cfb2d46b5f10633e9f6a9a36b8cb76f bench: Move generated data to a dedicated translation unit (João Barbosa)

Pull request description:

With this change multiple benchmarks can use the same data without incurring in a bigger binary.

ACKs for top commit:

laanwj:
  code review ACK 3d60a03a7cfb2d46b5f10633e9f6a9a36b8cb76f

Tree-SHA512: 8903bb09e4327c88e585a09bc7df1cbdfc18ebdc5d9c86bf3d6d9252a05eaf18b14ecd2bafdacd82f05a659e4b35ecd301c36011c97f7bf89302793165b00fdc

Backport of Core PR16299

Test Plan
ninja check bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16299
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10615
Build 19039: Default Diff Build & Tests
Build 19038: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 6 2020, 17:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2020, 17:22
jasonbcox requested review of this revision.May 6 2020, 17:22
teamcity edited the summary of this revision. (Show Details)May 6 2020, 17:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 6 2020, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix requested changes to this revision.May 6 2020, 17:23
deadalnix added a subscriber: deadalnix.

PR123456 ?

This revision now requires changes to proceed.May 6 2020, 17:23
deadalnix accepted this revision.May 6 2020, 17:29
This revision is now accepted and ready to land.May 6 2020, 17:29
jasonbcox added a child revision: D5981: Merge #16267: bench: Benchmark blockToJSON.May 6 2020, 17:30
teamcity added a comment.May 6 2020, 17:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10615: Diff 19752.May 6 2020, 17:32
Closed by commit rABC33b30bc21b60: Merge #16299: bench: Move generated data to a dedicated translation unit (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyMay 6 2020, 17:39
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC33b30bc21b60: Merge #16299: bench: Move generated data to a dedicated translation unit.
jasonbcox added a commit: rSTAGING33b30bc21b60: Merge #16299: bench: Move generated data to a dedicated translation unit.

Revision Contents
Changeset List

PathSize
src/
6 lines
bench/
1 line
21 lines
19 lines
16 lines
data/
2 lines

Diff 19752

View Options

src/Makefile.bench.include

Loading...
View Options

src/bench/CMakeLists.txt

Loading...
View Options

src/bench/checkblock.cpp

Loading...
View Options

src/bench/data.h

Loading...
View Options

src/bench/data.cpp

Loading...
View Options

src/bench/data/convert-raw-to-header.py

Loading...