Page MenuHomePhabricator

Merge #16299: bench: Move generated data to a dedicated translation unit
ClosedPublic

Authored by jasonbcox on May 6 2020, 17:22.

Details

Summary

3d60a03a7cfb2d46b5f10633e9f6a9a36b8cb76f bench: Move generated data to a dedicated translation unit (João Barbosa)

Pull request description:

With this change multiple benchmarks can use the same data without incurring in a bigger binary.

ACKs for top commit:

laanwj:
  code review ACK 3d60a03a7cfb2d46b5f10633e9f6a9a36b8cb76f

Tree-SHA512: 8903bb09e4327c88e585a09bc7df1cbdfc18ebdc5d9c86bf3d6d9252a05eaf18b14ecd2bafdacd82f05a659e4b35ecd301c36011c97f7bf89302793165b00fdc

Backport of Core PR16299

Test Plan
ninja check bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16299
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10615
Build 19039: Default Diff Build & Tests
Build 19038: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 6 2020, 17:23
deadalnix added a subscriber: deadalnix.

PR123456 ?

This revision now requires changes to proceed.May 6 2020, 17:23
This revision is now accepted and ready to land.May 6 2020, 17:29