Page MenuHomePhabricator
Differential D6008

Merge #15463: rpc: Speedup getaddressesbylabel
ClosedPublic
Actions

Authored by jasonbcox on May 8 2020, 00:28.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel
rABC54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel
Summary

710a7136f9 rpc: Speedup getaddressesbylabel (João Barbosa)

Pull request description:

Fixes #15447. Same approach of #14984, this change avoids duplicate key check when building the JSON response in memory.

ACKs for commit 710a71:

MarcoFalke:
  utACK 710a7136f93133bf256d37dc8c8faf5a6b9ba89d
ryanofsky:
  utACK 710a7136f93133bf256d37dc8c8faf5a6b9ba89d. Just new comments and assert since last review.

Tree-SHA512: 77c95df9ff3793e348619aa070e6fd36df9da1b461d708ab146652cb3699f1a472ef6eb38dafdb8374375cbc97daef07635fcb0501961f167a023309513742e2

Backport of Core PR15463

Similar improvement to D6007

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15463
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10655
Build 19116: Default Diff Build & Tests
Build 19115: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 8 2020, 00:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2020, 00:28
jasonbcox requested review of this revision.May 8 2020, 00:28
teamcity edited the summary of this revision. (Show Details)May 8 2020, 00:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 8 2020, 00:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 8 2020, 00:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10655: Diff 19835.May 8 2020, 00:37
deadalnix accepted this revision.May 8 2020, 00:51
This revision is now accepted and ready to land.May 8 2020, 00:51
Closed by commit rABC54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyMay 8 2020, 14:49
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel.
jasonbcox added a commit: rSTAGING54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel.

Revision Contents
Changeset List

PathSize
src/
wallet/
14 lines

Diff 19835

View Options

src/wallet/rpcwallet.cpp

Loading...