Page MenuHomePhabricator

[backport#14356] fix converttopsbt permitsigdata arg, add basic test
ClosedPublic

Authored by majcosta on May 11 2020, 13:23.

Details

Summary

The final check for extraneous sigdata has a flipped boolean, resulting in incorrect behavior.


This is a backport of Core PR14356

Test Plan
ninja check
./test_runner.py rpc_psbt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 11 2020, 13:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 13:24
majcosta requested review of this revision.May 11 2020, 13:24
teamcity edited the summary of this revision. (Show Details)May 11 2020, 13:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta retitled this revision from [backport#15408] fix converttopsbt permitsigdata arg, add basic test to [backport#14356] fix converttopsbt permitsigdata arg, add basic test.May 11 2020, 13:25
majcosta edited the summary of this revision. (Show Details)
deadalnix accepted this revision.May 11 2020, 13:48
This revision is now accepted and ready to land.May 11 2020, 13:48