[backport#14356] fix converttopsbt permitsigdata arg, add basic test
ClosedPublic
Actions

Authored by majcosta on May 11 2020, 13:23.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING5517f469f9e5: [backport#14356] fix converttopsbt permitsigdata arg, add basic test
rABC5517f469f9e5: [backport#14356] fix converttopsbt permitsigdata arg, add basic test

Summary

The final check for extraneous sigdata has a flipped boolean, resulting in incorrect behavior.

This is a backport of Core PR14356

Test Plan

ninja check
./test_runner.py rpc_psbt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15408

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10682
Build 19161: Default Diff Build & Tests
Build 19160: arc lint + arc unit

Event Timeline

majcosta created this revision.May 11 2020, 13:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 13:24

majcosta requested review of this revision.May 11 2020, 13:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta retitled this revision from [backport#15408] fix converttopsbt permitsigdata arg, add basic test to [backport#14356] fix converttopsbt permitsigdata arg, add basic test.May 11 2020, 13:25

majcosta edited the summary of this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10682: Diff 19880.May 11 2020, 13:33

deadalnix accepted this revision.May 11 2020, 13:48

This revision is now accepted and ready to land.May 11 2020, 13:48

Closed by commit rABC5517f469f9e5: [backport#14356] fix converttopsbt permitsigdata arg, add basic test (authored by Gregory Sanders <gsanders87@gmail.com>, committed by majcosta). · Explain WhyMay 11 2020, 14:06

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC5517f469f9e5: [backport#14356] fix converttopsbt permitsigdata arg, add basic test.

majcosta added a commit: rSTAGING5517f469f9e5: [backport#14356] fix converttopsbt permitsigdata arg, add basic test.May 11 2020, 14:10

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

6 lines

test/

functional/

rpc_psbt.py

7 lines

Diff 19880

View Options

src/rpc/rawtransaction.cpp