Page MenuHomePhabricator
Differential D6032

[backport#15632] [wallet] Remove unnecessary Chain::Lock parameter from ResendWalletTransactions
ClosedPublic
Actions

Authored by majcosta on May 11 2020, 16:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4920c60cc07d: [backport#15632] [wallet] Remove unnecessary Chain::Lock parameter from…
rABC4920c60cc07d: [backport#15632] [wallet] Remove unnecessary Chain::Lock parameter from…
Summary

https://github.com/bitcoin/bitcoin/pull/15632/commits/833d98ae073daf0f25f786f043f2ffa85155c8ff

This completes the backport of Core PR15632

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15632
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10692
Build 19181: Default Diff Build & Tests
Build 19180: arc lint + arc unit

Event Timeline

majcosta created this revision.May 11 2020, 16:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 16:55
majcosta requested review of this revision.May 11 2020, 16:55
teamcity edited the summary of this revision. (Show Details)May 11 2020, 16:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 11 2020, 16:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 11 2020, 17:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10692: Diff 19894.May 11 2020, 17:05
deadalnix accepted this revision.May 11 2020, 17:07
This revision is now accepted and ready to land.May 11 2020, 17:07
Closed by commit rABC4920c60cc07d: [backport#15632] [wallet] Remove unnecessary Chain::Lock parameter from… (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 11 2020, 17:54
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC4920c60cc07d: [backport#15632] [wallet] Remove unnecessary Chain::Lock parameter from….
majcosta added a commit: rSTAGING4920c60cc07d: [backport#15632] [wallet] Remove unnecessary Chain::Lock parameter from….

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
15 lines

Diff 19894

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...