Fix incorrect mocktime set in miner fund test
ClosedPublic
Actions

Authored by jasonbcox on May 15 2020, 13:19.

Details

Reviewers

nakihito
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING3455faac52a9: Fix incorrect mocktime set in miner fund test
rABC3455faac52a9: Fix incorrect mocktime set in miner fund test

Summary

node.setmocktime() is called but the node is restarted immediately after.
Move setting the mock time to after the node starts back up since it's restarted many
times in this test.

Test Plan

test_runner.py abc-miner-fund

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 15 2020, 13:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 15 2020, 13:19

jasonbcox requested review of this revision.May 15 2020, 13:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

nakihito accepted this revision.May 15 2020, 13:23

This revision is now accepted and ready to land.May 15 2020, 13:23

Fabien accepted this revision.May 15 2020, 13:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10787: Diff 20092.May 15 2020, 13:35

Closed by commit rABC3455faac52a9: Fix incorrect mocktime set in miner fund test (authored by jasonbcox). · Explain WhyMay 15 2020, 13:39

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC3455faac52a9: Fix incorrect mocktime set in miner fund test.

jasonbcox added a commit: rSTAGING3455faac52a9: Fix incorrect mocktime set in miner fund test.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-miner-fund.py

2 lines

Diff 20093

View Options

test/functional/abc-miner-fund.py

Fix incorrect mocktime set in miner fund testClosedPublicActions