Page MenuHomePhabricator

Check for IBD completion based on existing log message instead of 100% progress
ClosedPublic

Authored by jasonbcox on May 16 2020, 00:18.

Details

Summary

This is a more accurate test since 100% progress is actually post-IBD.

This will shorten the IBD test time as well as stabilize the amount of time it takes.
Currently, it's possible for a node to sit at 99.99% completion for tens of minutes
despite IBD being complete.

Test Plan

Run IBD on CI

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.May 16 2020, 00:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2020, 00:18
jasonbcox requested review of this revision.May 16 2020, 00:18
deadalnix accepted this revision.May 16 2020, 01:44
This revision is now accepted and ready to land.May 16 2020, 01:44

Note that there is an RPC call for this.