Page MenuHomePhabricator
Differential D6100

Check for IBD completion based on existing log message instead of 100% progress
ClosedPublic
Actions

Authored by jasonbcox on May 16 2020, 00:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING549166a5c7eb: Check for IBD completion based on existing log message instead of 100% progress
rABC549166a5c7eb: Check for IBD completion based on existing log message instead of 100% progress
Summary

This is a more accurate test since 100% progress is actually post-IBD.

This will shorten the IBD test time as well as stabilize the amount of time it takes.
Currently, it's possible for a node to sit at 99.99% completion for tens of minutes
despite IBD being complete.

Test Plan

Run IBD on CI

Diff Detail

Event Timeline

jasonbcox created this revision.May 16 2020, 00:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2020, 00:18
jasonbcox requested review of this revision.May 16 2020, 00:18
teamcity added a comment.May 16 2020, 00:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 16 2020, 00:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 16 2020, 00:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 16 2020, 00:19

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing (build-ibd) started.

teamcity added a comment.May 16 2020, 00:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 16 2020, 00:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 16 2020, 00:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10801: Diff 20133.May 16 2020, 00:35
deadalnix accepted this revision.May 16 2020, 01:44
This revision is now accepted and ready to land.May 16 2020, 01:44
teamcity added a comment.May 16 2020, 03:06

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing (build-ibd) passed.

deadalnix added a comment.May 16 2020, 17:01

Note that there is an RPC call for this.

Closed by commit rABC549166a5c7eb: Check for IBD completion based on existing log message instead of 100% progress (authored by jasonbcox). · Explain WhyMay 18 2020, 15:19
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC549166a5c7eb: Check for IBD completion based on existing log message instead of 100% progress.
jasonbcox added a commit: rSTAGING549166a5c7eb: Check for IBD completion based on existing log message instead of 100% progress.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
2 lines

Diff 20133

View Options

contrib/teamcity/ibd.sh

Loading...