Page MenuHomePhabricator

MalFix: Drop support for GetTransaction lookups using the UTXO-index
AbandonedPublic

Authored by jasonbcox on Oct 18 2017, 07:51.

Details

Reviewers
deadalnix
tomtomtom7
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Get transaction request used to (slowly) lookup transactions using the
UTXO-database even if -txindex was disabled. This is deprecated.

Either -txindex is used to lookup all transactions or only the mempool
is searched.

Test Plan

This effects a lot of rpc tests as they rely on the slow lookup. These
are adepted in a later diff.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D597
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1007
Build 1007: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 18 2017, 07:51
deadalnix requested changes to this revision.Dec 5 2017, 14:51
deadalnix added a subscriber: deadalnix.

This should not break a ton of tests. If it does, then the test need to be fixed first, or at the same time.

It's also not clear to me why we want to delete this ?

This revision now requires changes to proceed.Dec 5 2017, 14:51
jasonbcox abandoned this revision.
jasonbcox added a reviewer: tomtomtom7.