Page MenuHomePhabricator

[testonly] [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
ClosedPublic

Authored by deadalnix on May 19 2020, 00:57.

Details

Summary

Only if -changetype is not set and -addresstype is not "legacy".

Implement some of the test changes from PR12119 . Basically stripped everything that is segwit realted, which is almost everything. The 5th node is now redundant.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.May 19 2020, 00:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 00:57
deadalnix requested review of this revision.May 19 2020, 00:57
teamcity edited the summary of this revision. (Show Details)May 19 2020, 00:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.May 19 2020, 12:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/wallet_address_types.py
23 ↗(On Diff #20256)

node4 => node3

206 ↗(On Diff #20256)

Needs update

This revision is now accepted and ready to land.May 19 2020, 12:09