Page MenuHomePhabricator
Differential D6143

[land-bot] Improve error reporting when fetching revision status fails
ClosedPublic
Actions

Authored by jasonbcox on May 19 2020, 16:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcfb493b7a1a7: [land-bot] Improve error reporting when fetching revision status fails
Summary

Prior to this patch, the request can fail for a number of reasons and provide
no helpful info to investigate the issue.

Test Plan
vim land-patch.sh    # edit the domain on the REVISION_STATUS line to a non-existent domain
CONDUIT_TOKEN=invalid ./land-patch --dry-run -r D5930   # Failed to connect to non-existent domain
git reset --hard <this-patch>
CONDUIT_TOKEN=invalid ./land-patch --dry-run -r D5930   # Gives Conduit error as expected
CONDUIT_TOKEN=<valid-token> ./land-patch --dry-run -r D5930   # Still errors as expected since this revision isn't accepted

Diff Detail

Event Timeline

jasonbcox created this revision.May 19 2020, 16:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 16:54
jasonbcox requested review of this revision.May 19 2020, 16:54
teamcity added a comment.May 19 2020, 16:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 16:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 16:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 17:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 17:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 17:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10859: Diff 20282.May 19 2020, 17:14
Fabien accepted this revision.May 21 2020, 11:56
This revision is now accepted and ready to land.May 21 2020, 11:56
Closed by commit rABCcfb493b7a1a7: [land-bot] Improve error reporting when fetching revision status fails (authored by jasonbcox). · Explain WhyMay 21 2020, 16:34
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCcfb493b7a1a7: [land-bot] Improve error reporting when fetching revision status fails.

Revision Contents
Changeset List

PathSize
contrib/
source-control-tools/
32 lines

Diff 20282

View Options

contrib/source-control-tools/land-patch.sh

Loading...