Page MenuHomePhabricator
Differential D6161

[MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid
ClosedPublic
Actions

Authored by Fabien on May 20 2020, 13:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCdf747e1aa493: [MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid
Summary

Partial backport of core PR17270:
https://github.com/bitcoin/bitcoin/pull/17270/commits/723c79666770b30cce9f962bed5ece8cc7d74580

Test Plan
ninja all check-all

Run the Gitian builds.

Diff Detail

Event Timeline

Fabien created this revision.May 20 2020, 13:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 13:34
Fabien requested review of this revision.May 20 2020, 13:34
teamcity edited the summary of this revision. (Show Details)May 20 2020, 13:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 13:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 13:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 13:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 13:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 13:41

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 13:47

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

teamcity added a comment.May 20 2020, 13:49

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

teamcity added a comment.May 20 2020, 13:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10888: Diff 20354.May 20 2020, 13:49
teamcity added a comment.May 20 2020, 13:54

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

teamcity added a comment.May 20 2020, 13:54

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

teamcity added a comment.May 20 2020, 14:00

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

Fabien added a child revision: D6162: Gather additional entropy from the environment.May 20 2020, 14:11
teamcity added a comment.May 20 2020, 14:31

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

deadalnix accepted this revision.May 20 2020, 17:20
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/crypto/sha256.cpp
8

Why is this needed?

This revision is now accepted and ready to land.May 20 2020, 17:20
deadalnix added inline comments.May 20 2020, 17:21
src/crypto/sha256.cpp
8

Got it, it just moved.

Closed by commit rABCdf747e1aa493: [MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyMay 21 2020, 13:29
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdf747e1aa493: [MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid.

Revision Contents
Changeset List

PathSize
src/
1 line
compat/
26 lines
crypto/
24 lines
18 lines

Diff 20354

View Options

src/Makefile.am

Loading...
View Options

src/compat/cpuid.h

Loading...
View Options

src/crypto/sha256.cpp

Loading...
View Options

src/random.cpp

Loading...