Page MenuHomePhabricator
Differential D6165

[backport#16995] refactor: Work around GCC 9 `-Wredundant-move` warning
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 15:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING565b9505849f: [backport#16995] refactor: Work around GCC 9 `-Wredundant-move` warning
rABC565b9505849f: [backport#16995] refactor: Work around GCC 9 `-Wredundant-move` warning
Summary

Use std::move workaround for unique_ptr, for when the C++ compiler lacks
a fix for this issue:
http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1579
Do this in a way that avoids a GCC 9 -Wredundant-move warning.

https://github.com/bitcoin/bitcoin/pull/16995/commits/ff9c671b11d40e5d0623eff3dd12e48cbaafb34e

This completes the backport of Core PR16995

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 20 2020, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 15:25
majcosta requested review of this revision.May 20 2020, 15:25
teamcity edited the summary of this revision. (Show Details)May 20 2020, 15:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 15:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 15:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 15:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 15:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 15:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 15:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10892: Diff 20360.May 20 2020, 15:40
deadalnix requested changes to this revision.May 20 2020, 17:11
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/interfaces/chain.cpp
267 ↗(On Diff #20360)

Comment on its own line.

This revision now requires changes to proceed.May 20 2020, 17:11
majcosta updated this revision to Diff 20373.May 20 2020, 18:15

placed comment on its own line

teamcity added a comment.May 20 2020, 18:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 18:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 18:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 18:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 18:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 18:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10903: Diff 20373.May 20 2020, 18:48
deadalnix accepted this revision.May 21 2020, 00:12
This revision is now accepted and ready to land.May 21 2020, 00:12
Closed by commit rABC565b9505849f: [backport#16995] refactor: Work around GCC 9 `-Wredundant-move` warning (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyMay 21 2020, 00:23
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC565b9505849f: [backport#16995] refactor: Work around GCC 9 `-Wredundant-move` warning.
majcosta added a commit: rSTAGING565b9505849f: [backport#16995] refactor: Work around GCC 9 `-Wredundant-move` warning.

Revision Contents
Changeset List

PathSize
src/
interfaces/
6 lines

Diff 20408

View Options

src/interfaces/chain.cpp

Loading...