Page MenuHomePhabricator

[backport#16995] refactor: Work around GCC 9 `-Wredundant-move` warning
ClosedPublic

Authored by majcosta on May 20 2020, 15:25.

Details

Summary

Use std::move workaround for unique_ptr, for when the C++ compiler lacks
a fix for this issue:
http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1579
Do this in a way that avoids a GCC 9 -Wredundant-move warning.

https://github.com/bitcoin/bitcoin/pull/16995/commits/ff9c671b11d40e5d0623eff3dd12e48cbaafb34e


This completes the backport of Core PR16995

Test Plan
ninja check

Event Timeline

majcosta created this revision.May 20 2020, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 15:25
majcosta requested review of this revision.May 20 2020, 15:25
teamcity edited the summary of this revision. (Show Details)May 20 2020, 15:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 20 2020, 17:11
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/interfaces/chain.cpp
267 ↗(On Diff #20360)

Comment on its own line.

This revision now requires changes to proceed.May 20 2020, 17:11
majcosta updated this revision to Diff 20373.May 20 2020, 18:15

placed comment on its own line

deadalnix accepted this revision.May 21 2020, 00:12
This revision is now accepted and ready to land.May 21 2020, 00:12