Page MenuHomePhabricator
Differential D6176

Recategorize seeder connections as not manual
ClosedPublic
Actions

Authored by nakihito on May 20 2020, 19:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING2cd65b6968aa: Recategorize seeder connections as not manual
rABC2cd65b6968aa: Recategorize seeder connections as not manual
Summary

After the seeder is started, there is no user input. As such, the
connections the seeder makes should not be considered manual.

Test Plan
ninja
./bitcoin-seeder -host=localhost -ns=blah.bitframe.org -port=8888 -mbox=info@bitframe.org --testnet --wipeban --wipeignore

There should be no behavioral changes.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.May 20 2020, 19:52
Owners added a reviewer: Restricted Owners Package.May 20 2020, 19:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 19:52
nakihito requested review of this revision.May 20 2020, 19:52
teamcity added a comment.May 20 2020, 19:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 19:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 19:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 19:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 19:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 20:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10910: Diff 20387.May 20 2020, 20:06
deadalnix accepted this revision.May 20 2020, 21:51
This revision is now accepted and ready to land.May 20 2020, 21:51
Closed by commit rABC2cd65b6968aa: Recategorize seeder connections as not manual (authored by nakihito). · Explain WhyMay 20 2020, 22:51
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC2cd65b6968aa: Recategorize seeder connections as not manual.
nakihito added a commit: rSTAGING2cd65b6968aa: Recategorize seeder connections as not manual.May 20 2020, 22:55
deadalnix mentioned this in D6127: Add options to seeder to determine initial seed list at start up.May 25 2020, 16:15

Revision Contents
Changeset List

PathSize
src/
seeder/
3 lines

Diff 20402

View Options

src/seeder/bitcoin.cpp

Loading...