Page MenuHomePhabricator
Differential D6210

netaddress: Update CNetAddr for ORCHIDv2
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 21:23.

Details

Reviewers
majcosta
Fabien
Group Reviewers
Restricted Project
Commits
rABC061ee57f69ea: netaddress: Update CNetAddr for ORCHIDv2
Summary

The original ORCHID prefix was deprecated as of 2014-03, the new
ORCHIDv2 prefix was allocated by RFC7343 as of 2014-07. We did not
consider the original ORCHID prefix routable, and I don't see any reason
to consider the new one to be either.

This is a backport of Core PR15689

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 21 2020, 21:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 21:23
deadalnix requested review of this revision.May 21 2020, 21:23
teamcity edited the summary of this revision. (Show Details)May 21 2020, 21:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 21:23

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 21:24

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 21:24

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

majcosta accepted this revision.May 21 2020, 21:26
This revision is now accepted and ready to land.May 21 2020, 21:26
teamcity added a comment.May 21 2020, 21:26

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Fabien accepted this revision.May 21 2020, 21:27
This revision was landed with ongoing or failed builds.May 21 2020, 21:27
Closed by commit rABC061ee57f69ea: netaddress: Update CNetAddr for ORCHIDv2 (authored by Carl Dong <accounts@carldong.me>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC061ee57f69ea: netaddress: Update CNetAddr for ORCHIDv2.
teamcity added a comment.May 21 2020, 21:29

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 21:36

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10958: Diff 20490.May 21 2020, 21:36

Revision Contents
Changeset List

PathSize
src/
4 lines
7 lines
test/
1 line

Diff 20492

View Options

src/netaddress.h

Loading...
View Options

src/netaddress.cpp

Loading...
View Options

src/test/netbase_tests.cpp

Loading...