Page MenuHomePhabricator
Differential D6211

random: mark RandAddPeriodic and SeedPeriodic as noexcept
ClosedPublic
Actions

Authored by Fabien on May 21 2020, 21:23.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCfce972a3a0b9: random: mark RandAddPeriodic and SeedPeriodic as noexcept
Summary
The usage of MilliSleep() in SeedPeriodic (previously SeedSleep) was
removed in #17270, meaning it, and its users can now be marked noexcept.

This also corrects the docs in random.h for some of the changes in #17270.

Backport of core PR17507.

Depends on D6209.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 21 2020, 21:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 21:23
Fabien requested review of this revision.May 21 2020, 21:23
teamcity edited the summary of this revision. (Show Details)May 21 2020, 21:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 21:24

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 21:24

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 21:24

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 21:31

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 21:32

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 21:36

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10959: Diff 20491.May 21 2020, 21:36
deadalnix accepted this revision.May 21 2020, 21:49
This revision is now accepted and ready to land.May 21 2020, 21:49
Closed by commit rABCfce972a3a0b9: random: mark RandAddPeriodic and SeedPeriodic as noexcept (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyMay 22 2020, 11:48
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfce972a3a0b9: random: mark RandAddPeriodic and SeedPeriodic as noexcept.

Revision Contents
Changeset List

PathSize
src/
18 lines
18 lines

Diff 20510

View Options

src/random.h

Loading...
View Options

src/random.cpp

Loading...