Differential D6219

[refactor] change orphan txs std::map member to use TxId instead of uint256
ClosedPublic
Actions

Authored by majcosta on May 22 2020, 15:12.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1ca8fd1636b0: [refactor] change orphan txs std::map member to use TxId instead of uint256

Summary

for type safety. as long as i'm touching those lines, I also added
auto liberally and const where appropriate

Test Plan

ninja check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 22 2020, 15:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 15:12

majcosta requested review of this revision.May 22 2020, 15:12

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

deadalnix requested changes to this revision.May 22 2020, 15:25

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/net_processing.cpp
1063 ↗	(On Diff #20513)	So it's not a hash, is it?
1131 ↗	(On Diff #20513)	So it is not a random hash, is it?
2891 ↗	(On Diff #20513)	dito

This revision now requires changes to proceed.May 22 2020, 15:25

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10970: Diff 20513.May 22 2020, 15:27

addressed comments, added more explicit names, replaced a constructor initialization with list initialization to guard against narrowind conversions, made a TxId function parameter const

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10972: Diff 20516.May 22 2020, 16:11

deadalnix requested changes to this revision.May 22 2020, 17:24

deadalnix added inline comments.

src/net_processing.cpp
1029 ↗	(On Diff #20516)	TxId is not any longer than auto and make things clearer.
1131 ↗	(On Diff #20516)	const TxId randomTxId(rng.rand256());
1251 ↗	(On Diff #20516)	TxId also, orphanId to match naming in the source material.
1260 ↗	(On Diff #20516)	revert
2891 ↗	(On Diff #20516)	just txid

This revision now requires changes to proceed.May 22 2020, 17:24

addressed comments

deadalnix accepted this revision.May 22 2020, 17:52

This revision is now accepted and ready to land.May 22 2020, 17:52

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10981: Diff 20527.May 22 2020, 18:06

Closed by commit rABC1ca8fd1636b0: [refactor] change orphan txs std::map member to use TxId instead of uint256 (authored by majcosta). · Explain WhyMay 22 2020, 18:11

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC1ca8fd1636b0: [refactor] change orphan txs std::map member to use TxId instead of uint256.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

43 lines

Diff 20529

src/net_processing.cpp

Loading...