Differential D6250

[refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const
ClosedPublic
Actions

Authored by majcosta on May 25 2020, 18:28.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCcbbcffd5072a: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const

Summary

it is correct for it to be so

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 25 2020, 18:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2020, 18:28

majcosta requested review of this revision.May 25 2020, 18:28

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11017: Diff 20597.May 25 2020, 18:39

Fabien accepted this revision.May 25 2020, 19:30

This revision is now accepted and ready to land.May 25 2020, 19:30

Closed by commit rABCcbbcffd5072a: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const (authored by majcosta). · Explain WhyMay 25 2020, 20:10

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCcbbcffd5072a: [refactor] make ArgsManager& parameter in IsDeprecatedRPCEnabled const.

Revision Contents
Changeset List

Path

Size

src/

rpc/

server.h

2 lines

server.cpp

3 lines

Diff 20602

View Options

src/rpc/server.h