Page MenuHomePhabricator
Differential D6254

Fix CPUID subleaf iteration
ClosedPublic
Actions

Authored by Fabien on May 26 2020, 11:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCbef4ef2954dd: Fix CPUID subleaf iteration
Summary
The code to determine which CPUID subleaves to explore was incorrect in
#17270. The new code here is based on Intel's reference documentation
for CPUID (a document called "Intel® Processor Identification and the
CPUID Instruction - Application Note 485", which I cannot actually find
on their own website).

Backport of core PR17527.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 26 2020, 11:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 11:22
Fabien requested review of this revision.May 26 2020, 11:22
teamcity edited the summary of this revision. (Show Details)May 26 2020, 11:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 26 2020, 11:22

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 11:22

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 11:22

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 11:24

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 11:26

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 11:35

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11025: Diff 20608.May 26 2020, 11:35
deadalnix accepted this revision.May 26 2020, 11:49
deadalnix added a subscriber: deadalnix.

Intel, always making a real mess.

This revision is now accepted and ready to land.May 26 2020, 11:49
Closed by commit rABCbef4ef2954dd: Fix CPUID subleaf iteration (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyMay 26 2020, 13:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCbef4ef2954dd: Fix CPUID subleaf iteration.

Revision Contents
Changeset List

PathSize
src/
38 lines

Diff 20613

View Options

src/randomenv.cpp

Loading...