Page MenuHomePhabricator
Differential D6266

rpc: Uncouple non-wallet rpcs from maxTxFee global
ClosedPublic
Actions

Authored by deadalnix on May 27 2020, 12:53.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC6c784a612512: rpc: Uncouple non-wallet rpcs from maxTxFee global
Summary
  • rpc: Use IsValidNumArgs over hardcoded size checks
  • rpc: Uncouple rpcs from maxTxFee global
  • doc: Add release notes for 15620

This is a backport of Core PR15620

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.May 27 2020, 12:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2020, 12:53
deadalnix requested review of this revision.May 27 2020, 12:53
teamcity edited the summary of this revision. (Show Details)May 27 2020, 12:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 27 2020, 12:53

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 27 2020, 12:53

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 27 2020, 12:53

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 27 2020, 12:55

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 27 2020, 12:56

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 27 2020, 13:03

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11044: Diff 20632.May 27 2020, 13:03
deadalnix added a child revision: D6267: [wallet] Move maxTxFee to wallet.May 27 2020, 13:32
jasonbcox accepted this revision.May 27 2020, 16:01
This revision is now accepted and ready to land.May 27 2020, 16:01
Closed by commit rABC6c784a612512: rpc: Uncouple non-wallet rpcs from maxTxFee global (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyMay 27 2020, 16:16
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC6c784a612512: rpc: Uncouple non-wallet rpcs from maxTxFee global.

Revision Contents
Changeset List

PathSize
doc/
9 lines
src/
rpc/
176 lines

Diff 20632

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...